spotify: update to 1.2.31.

[hsnovel]

Testing the changes

• I tested the changes in this PR: YES

Local build testing

• I built this PR locally for my native architecture, (x86_64)

Current upstream does not work. Log:

=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://repo-default.voidlinux.org/current/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> spotify-1.2.26_1: removing autodeps, please wait...
=> spotify-1.2.26_1: building for x86_64...
   [host] libcurl-8.6.0_1: found (https://repo-default.voidlinux.org/current)
   [runtime] libcurl-8.6.0_1: found (https://repo-default.voidlinux.org/current)
=> spotify-1.2.26_1: installing host dependencies: libcurl-8.6.0_1 ...
=> spotify-1.2.26_1: running do-fetch hook: 00-distfiles ...
=> spotify-1.2.26_1: fetching distfile 'spotify-client_1.2.26.1187.g36b715a1_amd64.deb' from 'http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.26.1187.g36b715a1_amd64.deb'...
http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.26.1187.g36b715a1_amd64.deb: Not Found
=> ERROR: spotify-1.2.26_1: failed to fetch 'spotify-client_1.2.26.1187.g36b715a1_amd64.deb'.

Version 1.2.31 exists on the upstream but Spotify launches with a gray screen on my testing machine. Current upstream does not exist thus, it might be a good idea to downgrade the version unless installation of 1.2.31 is confirmed to work correctly.

Edit:
I am unsure as if this problem only exists for me but even tough Spotify launches correctly it gives an error during login saying:
A firewall may be blocking Spotify. Please update your firewall to allow Spotify. Additionally you could try changing the currently used proxy settings

I need further confirmation and testing as both 1.2.31 and 1.1.26 seem to be working incorrectly on my machine.

[dataCobra]

Latest upstream works fine on my Laptop and Desktop PC.

[hsnovel]

Do you mean 1.2.26 (latest on this void-packages repo) or 1.2.31 (latest on the debian upstream repo)?

[dataCobra]

I meant the latest version that spotify is providing. But I can confirm 1.2.26 and 1.2.31 are working fine on my machines.

[dataCobra]

As your error message suggests it seems that spotify is not able to reach the network.

In that case you could create an issue for help and close this PR.

[hsnovel]

I can reach the network very well. I downloaded other packages from xbps-install to test if the issue was only happening on Spotify and it is. The upstream simply does not exist. I am writing this message with a very stable internet connection. Unless this link http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.26.1187.g36b715a1_amd64.deb is blocked in Germany I should be able to reach but I can not as it does not exist.

[hsnovel]

As your error message suggests it seems that spotify is not able to reach the network.

In that case you could create an issue for help and close this PR.

I can close the pr but the current upstream does not exist. wget the address: http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.26.1187.g36b715a1_amd64.deb and tell me if it returns anything. Even if I close the pr the current upstream does not exists. In that case I can push another commit to upgrade the version to 1.2.31.

[dataCobra]

Sadly Spotify overwrites versions if there is a new one.

http://repository.spotify.com/pool/non-free/s/spotify-client/

So the 1.2.26 got overwritten by 1.2.31.
As said I've already tested 1.2.31 fine on both my machines. So feel free to update and test it out once again. Did you found the reason why Spotify isn't working on your test machine?

[hsnovel]

Yes I found the problem.

Since I barley use any GUI apps on my testing machine I never noticed DBUS_SESSION_BUS_ADDRESS was only set in .bashrc and not in .profile so GUI apps didn't pick up the address. I pushed another commit to update to version 1.2.31.

[Clos3y]

I pushed another commit to update to version 1.2.31.

You need to squash the commits and rename the PR.

void-packages/CONTRIBUTING.md

Line 127 in 6511144

Once you have made and verified your changes to the package template and/or other files, make one commit per package (including all changes to its sub-packages). Each commit message should have one of the following formats:

[hsnovel]

done.

[classabbyamp]

commit message should just be spotify: update to 1.2.31.

[classabbyamp]

#49559