pdfpc: disable REST server #48959
Merged
pdfpc: disable REST server #48959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please write one sentence why. There's probably a good reason. ;) Also |
Sorry about that. I thought I did, but I think it got lost and I didn't notice. |
|
I would write the whole paragraph into commit msg:
|
Build with libwebkit2gtk41 REST server functionality requires libsoup2, however libsoup2 cannot be loaded in to the same process as libsoup3. One of the maintainers reccomended disabling REST and building presentation notes with webkit2gtk-4.1, stating that as far as he knows, he is the only one using the REST server functionality. pdfpc/pdfpc#671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Build with webkit2gtk-4.1, which provides an identical api to webkit2gtk-4.0 except it uses libsoup3.
The REST server functionality requires libsoup2. libsoup2 and libsoup3 cannot be loaded in the same process at the same time.
One of the maintainers recommended just disabling the rest server and building the markdown presentation notes viewer with webkit2gtk-4.1 stating that as far as he knows, he is the only one that actually uses the rest server function. pdfpc/pdfpc#671 (comment)
I was wondering if anyone here that uses pdfpc uses the rest server function?