Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foliate: add missing libadwaita dependency #49000

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

lipidity
Copy link
Contributor

When libadwaita is not installed, foliate crashes on launch with the following error:

JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28 @gi://Adw?version=1:3:25

Testing the changes

  • I tested the changes in this PR: briefly (foliate stopped crashing after I installed libadwaita)

@sgn
Copy link
Member

sgn commented Feb 29, 2024

Bump revision to 2, please.

When libadwaita is not installed, foliate crashes on launch.
@oreo639
Copy link
Member

oreo639 commented Feb 29, 2024

It needs to be one commit, you can do:

git reset --soft HEAD~
git commit --amend

@oreo639 oreo639 merged commit feef21a into void-linux:master Feb 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants