Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/shlibs: add missing shlibs #49003

Closed
wants to merge 1 commit into from

Conversation

chrysos349
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@Chocimier
Copy link
Member

What package fails to build due to lack of these entries?

@chrysos349
Copy link
Contributor Author

Those that depend on those shlibs. From my private repo. Why does it matter?

fwupd, gst-plugins-bad1, gst-rtsp-server, zopfli are in the official repo, and provide the shared libs which need to be in the common/shlibs file.

@Chocimier
Copy link
Member

provide the shared libs which need to be in the common/shlibs

Wrong assumption, we usually do not list shared libs in shlibs unless used by other package.

Why does it matter?

Packages would likely need a revbump, and you added none in the PR what raised my question.

From my private repo.

Enough for me, but I'll like to hear opinion from other maintainers.

@abenson
Copy link
Contributor

abenson commented Feb 29, 2024

If these entries aren't needed for anything else that currently exists in void-packages, they can live on the same branch as your custom templates.

Additionally, these are unrelated to each other, and each one should be located within the file next to their similar entries (i.e. keep entries for gst-plugins-bad1 with the existing entries for gst-plugins-bad1.

@chrysos349 chrysos349 closed this Mar 1, 2024
@chrysos349 chrysos349 deleted the shlibs branch March 1, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants