Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strace: rebuild against newer libunwind #49037

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

meator
Copy link
Contributor

@meator meator commented Mar 2, 2024

This fixes the

strace: Symbol `_UPT_accessors' has different size in shared object, consider re-linking

warning. I don't know what causes this warning. A proper solution that would prevent this warning from appearing again in the future would probably be better.

Testing the changes

  • I tested the changes in this PR: YES

@icp1994
Copy link
Contributor

icp1994 commented Mar 2, 2024

That's libunwind

@oreo639
Copy link
Member

oreo639 commented Mar 2, 2024

The message is coming from glibc: https://github.com/bminor/glibc/blob/d370155b9ab73d0c45bf968b7a9c823f4697a505/sysdeps/x86_64/dl-machine.h#L460

_UPD_accessors is a variable defined by libunwind that gets externed and the struct size was changed here: libunwind/libunwind@d7e5926

The only use of _UPD_accessors in strace is passing its pointer back in to libunwind so afaict it shouldn't cause any noticeable issues in this instance: https://github.com/strace/strace/blob/8c480270653da45370fe44871dfdf18647bb0951/src/unwind-libunwind.c#L24

That being said, it should still be rebuilt as this is an ABI break.

Update the commit message to include the reason for the revbump and include the libunwind commit in the commit description.

This fixes the

strace: Symbol `_UPT_accessors' has different size in shared object,
consider re-linking

warning.

An ABI break was introduced in
libunwind/libunwind@d7e5926
@meator meator changed the title strace: revbump strace: rebuild against newer libunwind Mar 2, 2024
@oreo639 oreo639 merged commit 6b63d41 into void-linux:master Mar 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants