Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glfw: update to 3.4 #49042

Closed
wants to merge 1 commit into from
Closed

glfw: update to 3.4 #49042

wants to merge 1 commit into from

Conversation

mkohlhaas
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Email address Enno Boland gottox@voidlinux.org is unreachable.

@mkohlhaas
Copy link
Contributor Author

Could you check the wayland side as I cannot test it on my box? I'm not sure about the created files. Had to remove the link to make it work.

short_desc="Multi-platform library for creating windows with OpenGL contexts"
maintainer="Enno Boland <gottox@voidlinux.org>"
short_desc="Multi-platform library for OpenGL, OpenGL ES and Vulkan"
maintainer="Orphaned <orphan@voidlinux.org>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description taken from the GLFW project.
Email address not reachable. Orphaned email address is used in the glfw-wayland package or vice versa.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glfw package hasn't been updated for almost two years. So I expect it to be abandoned.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gottox isn't very active but is a member of the core team. don't orphan it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll write him in both packages.

Can I reach him somehow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change the maintainer fields at all.

@Gottox

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to change it to orphaned for me.

@M374LX
Copy link

M374LX commented Mar 6, 2024

While previous GLFW versions required separate builds for X11 and Wayland, the new version can detect the platform at runtime and a single build should be able to run on both X11 and Wayland.

I would say the glfw-wayland package is no longer necessary and should be removed.

@mkohlhaas mkohlhaas force-pushed the glfw branch 3 times, most recently from 01c87d9 to 2bbfd46 Compare March 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants