-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibc: clean up install, add C.UTF-8 by default #49146
Conversation
0999318
to
1b0e925
Compare
For bikeshedding, I added the proposed linter exception. |
1b0e925
to
f03838d
Compare
Afaict, the outputs generated by You can see how Debian handles it here: |
f03838d
to
508f007
Compare
Changes adopted. For native builds, we can just use the make target; for cross builds, we will fall back to the host utility with proper endianness. |
Thinking about it more, using the system |
We don't generally support cross-compiling across C libraries, and I'm not sure about the wisdom of requiring |
Yeah. |
We should really provide the
C.UTF-8
locale by default. I believe that the best way to do so is by removing it entirely from/etc/default/libc-locales
processing and install it, as part of the mainglibc
package, in/usr/lib/locales
like Arch does.This currently trips the package linter, so either
INSTALL
script to the base package to write theC.utf-8
locale outside of an archive, where it will always be reachable.I favor the first because it is less wasteful; why should everybody have to generate a locale that we expect everybody to have available by default?
A third option is to modify the
glibc-locales
INSTALL
script to either add a separate, non-archivedC.utf-8
locale directory, or just ensure thatC.UTF-8
is always included in the locale processing. Both seem even more kludgey than doing the right thing by default.Thoughts? @void-linux/pkg-committers
While I was at it, I cleaned up the install function a bit.