slack-desktop: allow the use of WebRTCPipeWireCapturer flag, adopt #49298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dataCobra :) |
mdkcore0
force-pushed
the
update-slack-desktop
branch
from
4d719a7
to
8d44faf
Compare
|
Thank you for the contribution. I'll test it under X11. |
|
I've successfully tested this PR and everything still works under X11. Since I'm currently not using the slack-desktop app with Void are you able to adopt the package and be the new maintainer? Because at the moment I can't guaranty that I can update and test the package in the future. |
|
hey, I can adopt, we use it for work, so I can keep it updated. Will update this PR to adopt it. |
mdkcore0
force-pushed
the
update-slack-desktop
branch
from
8d44faf
to
0921641
Compare
mdkcore0
changed the title
Slack seems to disable screen sharing on Wayland [1], so this commit allow the use of WebRTCPipeWireCapturer. Note that the user still need to add the flag on the command line to enable it: --enable-features=WebRTCPipeWireCapturer --ozone-platform-hint=auto. [1] https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work
mdkcore0
force-pushed
the
update-slack-desktop
branch
from
0921641
to
1096492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack seems to disable screen sharing on Wayland, this commit allow the use of WebRTCPipeWireCapturer.
Final user still needs to add the flag on the command line to make use of it:
--enable-features=WebRTCPipeWireCapturer --ozone-platform-hint=auto.Note: just tested on Wayland, it would be great if someone tested it on x11 too.
Note2: As discussed below with @dataCobra, I'm adopting this package.
Testing the changes
Local build testing