Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux6.x: backport fix for kexec regression #49529

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

ahesford
Copy link
Member

All of our linux6.x kernel series include a change that breaks kexec on certain hardware, notably AMD CPUs using various iterations of the Zen microarchitecture. I can reproduce the issue on my Zen 3 CPU, while other reports reveal that this problem affects ZFSBootMenu users on other iterations. I bisected the problem and confirmed that it is caused by the same commit that seems to impact users more generally. Consequently, the current upstream fix is to just revert the change.

While I was backporting the reversion, I took the liberty of updating linux6.1 as well.

I'm in the process of building and testing kernels with these patches to confirm that it fixes the ZFSBootMenu problem I observed and, assuming so, plan to bump our kernels to include the fix.

cc: @sgn @Duncaen

[ci skip]

Testing the changes

  • I tested the changes in this PR: in process

@sgn
Copy link
Member

sgn commented Mar 25, 2024

Yes, that commit should be reverted, seeing that in urgency, I think there'll be a stable release soon, no?

@ahesford
Copy link
Member Author

I've built these kernels for aarch64 and x86_64 and confirm that the revert fixes booting with ZFSBootMenu for every kernel series in this PR.

We can wait a day or two to see if new kernels are forthcoming. I see some announcements for 6.1 and 6.6 RC windows, but the revert does not appear in the changelog. We should make sure this is included in the next release, or we'll have to carry patches for awhile.

@dkwo
Copy link
Contributor

dkwo commented Mar 27, 2024

New kernels today, but I can only see that patch in linux-next.

@ahesford
Copy link
Member Author

Bumped all kernels, currently testing builds on all of them to make sure there are no surprises.

@ahesford
Copy link
Member Author

Currently all kernels fail to build on musl: https://bugzilla.kernel.org/show_bug.cgi?id=218647

@ahesford ahesford marked this pull request as draft March 27, 2024 14:40
@ahesford ahesford marked this pull request as ready for review March 28, 2024 13:56
@ahesford
Copy link
Member Author

Looks like Alpine found a fix, so I'm build-testing all of them again.

@sgn sgn merged commit 289e6ad into void-linux:master Mar 28, 2024
2 checks passed
@ahesford ahesford deleted the kexec-regression branch April 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants