-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wesnoth: update to 1.18.0. #49545
wesnoth: update to 1.18.0. #49545
Conversation
For x86_64 build is fine locally (I've checked it multiple times). Though for musl some extra patching needs to be done. Working on it. |
40e69ef
to
ee9bee6
Compare
I built template successfully on: x86_64, i686, x86_64-musl, aarch64-musl. Will add proofs if CI checks will fail |
1b625fb
to
7589dbf
Compare
d9dfb59
to
fec9947
Compare
Added pull request on wesnoth to fix musl build bug: wesnoth/wesnoth#8628 |
fec9947
to
1fd2b5c
Compare
I don't know what to do. Old SDL2_image version doesn't seem to be a thing |
2008833
to
f9bac9f
Compare
Changes:
|
Instead of adding a patch, add If done correctly, this should be part of the configure step's output for SDL2_image:
|
I tried it. Didn't work. Maybe I was too tired bruteforcing the answer and did something wrong. I'll try it againg |
You might need to Thanks for working on the update, by the way. I do want to play Wesnoth 1.18 at some point. |
Thanks a lot for your reviews! :) |
1e62cea
to
357ced3
Compare
357ced3
to
bc6199d
Compare
Added wesnoth developers' patch to fix musl instead of mine: wesnoth/wesnoth#8649 |
bc6199d
to
d67d1be
Compare
d67d1be
to
28c5a50
Compare
I tested the changes in this PR: YES
Checked out new compaign.
I built this PR locally for my native architecture, (x86_64-glibc)
Patch for boost is no longer needed as it was commited to 1.17 version.
Added libcurl as changelog says wesnoth now needs it for compiling.