Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreutils: update to 9.5. #49585

Closed

Conversation

iFoundSilentHouse
Copy link
Contributor

  • I tested the changes in this PR: briefly
  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures:
    • aarch64-musl

Split buffer bug was fixed in coreutils/coreutils@c4c5ed8 commit. So patch no longer needed

@classabbyamp classabbyamp added the core core package label Mar 29, 2024
@classabbyamp
Copy link
Member

I tested the changes in this PR: briefly

something as core as coreutils should be tested more than briefly

@iFoundSilentHouse iFoundSilentHouse marked this pull request as draft March 29, 2024 02:55
@iFoundSilentHouse iFoundSilentHouse changed the title coreutils: update to 9.5. [WIP] coreutils: update to 9.5. Mar 29, 2024
@iFoundSilentHouse
Copy link
Contributor Author

iFoundSilentHouse commented Mar 29, 2024

How can I prevent make_check from skipping locally when cross-compiling? Or it's better to create separate x86_64-musl masterdir?

@classabbyamp
Copy link
Member

you can't run tests when cross-compiling

see the readme for the musl masterdir

@iFoundSilentHouse
Copy link
Contributor Author

iFoundSilentHouse commented Mar 31, 2024

Tests /tests that fail locally on x86_64-musl : join, expr, cut, uniq, dd/no-allocate.
Tests /gnulib-tests that fail locally on x86_64-musl: canonicalize, test-getcwd.sh, test-getlogin.

In CI: only gnulib-tests/canonicalize with test-canonicalize.c:411: assertion 'strcmp (result1, "//") == 0' failed

@iFoundSilentHouse
Copy link
Contributor Author

test-canonicalize.c patch source: https://www.mail-archive.com/bug-coreutils%40gnu.org/msg33507.html

@iFoundSilentHouse iFoundSilentHouse marked this pull request as ready for review April 2, 2024 16:05
@iFoundSilentHouse
Copy link
Contributor Author

I'm already using it for 5 days, though imo it needs more testing. @classabbyamp would you mind adding needs-testing label to this PR?

@iFoundSilentHouse iFoundSilentHouse changed the title [WIP] coreutils: update to 9.5. coreutils: update to 9.5. Apr 2, 2024
@classabbyamp classabbyamp added the needs-testing Testing a PR or reproducing an issue needed label Apr 2, 2024
@iFoundSilentHouse
Copy link
Contributor Author

Which changes were tested:

  • cp, mv, cat, split, sort. This utils were changed fundamentally.
  • mv --exchange
  • env -a
  • chgrp --from=OWNER:GROUP

Copy link

github-actions bot commented Jul 9, 2024

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jul 9, 2024
@github-actions github-actions bot closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core core package needs-testing Testing a PR or reproducing an issue needed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants