bash-completion: update to 2.12.0.

[Vinfall]

Two backported patches from upstream (i.e. #688 and #675) are deleted since the new version includes them already.

Testing the changes

• I tested the changes in this PR: briefly

This PR FAILS to build on x86_64-musl with the following warnings:

=> xbps-src: updating repositories for host (x86_64-musl)...
[*] Updating repository `https://repo-default.voidlinux.org/current/musl/bootstrap/x86_64-musl-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/musl/debug/x86_64-musl-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> bash-completion-2.12.0_1: removing autodeps, please wait...
=> bash-completion-2.12.0_1: building with [gnu-configure] for x86_64-musl...
   [runtime] bash-5.2.21_1: found (https://repo-default.voidlinux.org/current/musl)
=> bash-completion-2.12.0_1: skipping check (XBPS_CHECK_PKGS is disabled) ...
=> bash-completion-2.12.0_1: running pre-pkg hook: 03-rewrite-python-shebang ...
=> bash-completion-2.12.0_1: running pre-pkg hook: 04-generate-runtime-deps ...
=> bash-completion-2.12.0_1: running pre-pkg hook: 05-generate-32bit-runtime-deps ...
=> bash-completion-2.12.0_1: running pre-pkg hook: 90-set-timestamps ...
=> bash-completion-2.12.0_1: setting mtimes to Fri Mar 29 07:05:08 UTC 2024
=> bash-completion-2.12.0_1: running pre-pkg hook: 99-pkglint-subpkgs ...
=> bash-completion-2.12.0_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: bash-completion-2.12.0_1: /etc/bash_completion.d is forbidden. Use /usr/share/bash-completion/completions.
=> ERROR: bash-completion-2.12.0_1: cannot continue with installation!

How can I solve the error /etc/bash_completion.d is forbidden. Use /usr/share/bash-completion/completions.? I searched a bit but could not find something useful.

[dataCobra]

Hey,

I've checked what the issue is and the pre-pkg hook 99-pkglint finds the path /etc/bash_completion.d in the installation path which is forbidden in Void.

There is only one file that is installed into that folder:
/etc/bash_completion.d/000_bash_completion_compat.bash

First of all you need to check if this file is mandatory for our distribution. If that is true, check for a way to move the file to the correct path and remove the wrong folder.

There might be a argument for configure to set the path or you need to modify the template file to make this happen.

[Vinfall]

Thanks for the heads-up. After taking a closer look, that folder is defined in Makefile.am in bash-completion and used to override the completion provided by it in a system wide range according to scop/bash-completion#201 and FAQ.

This is solved by adding a additional make install argument, but I'm not sure if there is a official or more appropriate way to do it. That being said, the build package works fine during my rough test on my x86_64-musl machine so it should be fine to merge.

[Vinfall]

Closing due to inactivity and lack of feedback.