-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3-feedparser: update to 6.0.11. #49647
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
srcpkgs/python3-feedparser/template
Outdated
depends="python3-sgmllib python3-requests" | ||
checkdepends="${depends} tox python3-pluggy" | ||
short_desc="Parse Atom/RSS/JSON feeds in Python3" | ||
maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We like to see a longer history of contributions before people adopt packages. Please leave the package orphaned for now.
srcpkgs/python3-feedparser/template
Outdated
depends="python3-sgmllib python3-requests" | ||
checkdepends="${depends} tox python3-pluggy" | ||
short_desc="Parse Atom/RSS/JSON feeds in Python3" | ||
maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>" | ||
license="BSD-2-Clause" | ||
homepage="https://pypi.org/project/feedparser/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update project homepage to reflect the site linked on the upstream source repository:
https://feedparser.readthedocs.io/
srcpkgs/python3-feedparser/template
Outdated
maintainer="Orphaned <orphan@voidlinux.org>" | ||
depends="python3-sgmllib python3-requests" | ||
checkdepends="${depends} tox python3-pluggy" | ||
short_desc="Parse Atom/RSS/JSON feeds in Python3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use upstream project description: "Parse feeds in Python".
srcpkgs/python3-feedparser/template
Outdated
short_desc="Parse Atom and RSS feeds in Python3" | ||
maintainer="Orphaned <orphan@voidlinux.org>" | ||
depends="python3-sgmllib python3-requests" | ||
checkdepends="${depends} tox python3-pluggy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tox
is not suitable for running checks with xbps-src
, as it fetches wheels in virtual environments and isn't actually testing what we build. If this package should be tested, you should pull in python3-pytest
here and fetch from the project's GitHub repository; the PyPI distribution contains no tests.
srcpkgs/python3-feedparser/template
Outdated
|
||
do_check() { | ||
tox | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary once tox
is dropped.
a39c0f4
to
2dc0b8e
Compare
Testing the changes
Local build testing