Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-feedparser: update to 6.0.11. #49647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adigitoleo
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (crossbuilds):
    • aarch64-musl
    • armv7l

@adigitoleo

This comment was marked as outdated.

depends="python3-sgmllib python3-requests"
checkdepends="${depends} tox python3-pluggy"
short_desc="Parse Atom/RSS/JSON feeds in Python3"
maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We like to see a longer history of contributions before people adopt packages. Please leave the package orphaned for now.

depends="python3-sgmllib python3-requests"
checkdepends="${depends} tox python3-pluggy"
short_desc="Parse Atom/RSS/JSON feeds in Python3"
maintainer="Leon (adigitoleo) <adigitoleo@posteo.net>"
license="BSD-2-Clause"
homepage="https://pypi.org/project/feedparser/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update project homepage to reflect the site linked on the upstream source repository:
https://feedparser.readthedocs.io/

maintainer="Orphaned <orphan@voidlinux.org>"
depends="python3-sgmllib python3-requests"
checkdepends="${depends} tox python3-pluggy"
short_desc="Parse Atom/RSS/JSON feeds in Python3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use upstream project description: "Parse feeds in Python".

short_desc="Parse Atom and RSS feeds in Python3"
maintainer="Orphaned <orphan@voidlinux.org>"
depends="python3-sgmllib python3-requests"
checkdepends="${depends} tox python3-pluggy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox is not suitable for running checks with xbps-src, as it fetches wheels in virtual environments and isn't actually testing what we build. If this package should be tested, you should pull in python3-pytest here and fetch from the project's GitHub repository; the PyPI distribution contains no tests.

Comment on lines 19 to 22

do_check() {
tox
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary once tox is dropped.

@adigitoleo adigitoleo requested a review from ahesford April 1, 2024 13:43
@adigitoleo adigitoleo changed the title python3-feedparser: update to 6.0.11, adopt. python3-feedparser: update to 6.0.11. Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants