Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: iamb-0.0.9 #49652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New package: iamb-0.0.9 #49652

wants to merge 1 commit into from

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Apr 1, 2024

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

closes #49586

@classabbyamp classabbyamp added the new-package This PR adds a new package label Apr 1, 2024
@AnInternetTroll
Copy link
Contributor

Tested on x86_64-glibc, joined a room and sent a message. Works as expected!

@AnInternetTroll
Copy link
Contributor

Super duper nitpick, but the manpage is technically wrong on void
https://github.com/ulyssa/iamb/blob/e5b284ed19cb99f79a0cbaca9e2339b9171e6d6d/docs/iamb.5#L541C1-L543C43

.Sy iamb
will load if the TOML one is not found.
.It Pa /usr/share/iamb/config.example.toml
A sample configuration file with examples of how to set different values.
.El

Should actually be /usr/share/examples/iamb/config.example.toml, with an added examples/

@AnInternetTroll
Copy link
Contributor

Tested it again with the lib changes and it still works

@Bnyro
Copy link
Contributor Author

Bnyro commented Apr 7, 2024

I guess we should report the test failure om i686 upstream?

@AnInternetTroll
Copy link
Contributor

I guess we should report the test failure om i686 upstream?

I've let them know on matrix that the one test is failing on 32bit (I assume it would fail on armv* as well if the CI would run those tests)

--

About my earlier comment on the manpage, what I meant to say is that maybe the manpage should be vsed'd to change that one line. Something like this for example

vsed -i docs/iamb.5 -e 's#/usr/share/iamb/config.example.toml#/usr/share/examples/iamb/config.example.toml#'

You should still vsconf the file though, that part was correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: iamb
3 participants