Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: fnm-1.35.1 #49718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New package: fnm-1.35.1 #49718

wants to merge 1 commit into from

Conversation

heppu
Copy link

@heppu heppu commented Apr 5, 2024

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture: x86_64
  • I built this PR locally for these architectures:
    • x86_64-musl
    • aarch64
    • aarch64-musl
    • armv6hf-musl
    • armv6hf
    • armv6l-musl
    • armv6l
    • armv7hf-musl
    • armv7hf
    • armv7l-musl
    • armv7l

@classabbyamp classabbyamp added the new-package This PR adds a new package label Apr 5, 2024
@heppu
Copy link
Author

heppu commented Apr 7, 2024

@classabbyamp Fixed the linting errors.

@classabbyamp
Copy link
Member

please don't ping me on PRs I'm not already involved in

@heppu
Copy link
Author

heppu commented Apr 7, 2024

Oh, I'm sorry. I thought it was you who allowed the workflow to be executed.

@Vinfall
Copy link
Contributor

Vinfall commented Jul 3, 2024

Are you still working on this? fnm before 1.36.0 does not really work on musl (due to hardcoded arch check, I made a PR to mitigate that in 1.36.0) although it does build. And it's no point to build for musl other than x86_64 as unofficial node mirror only has x64-musl tarballs.

@Vinfall
Copy link
Contributor

Vinfall commented Jul 3, 2024

You may find this patch useful:

--- template	2024-07-03 04:20:29.000000000 +0000
+++ template	2024-07-03 04:19:26.000000000 +0000
@@ -1,18 +1,19 @@
 # Template file for 'fnm'
 pkgname=fnm
-version=1.35.1
+version=1.37.1
 revision=1
+archs="x86_64-musl ~*-musl"
 build_style=cargo
 build_helper=qemu
 hostmakedepends="pkg-config"
 makedepends="libzstd-devel"
 short_desc="Fast and simple Node.js version manager, built in Rust"
 maintainer="Henri Koski <henri.t.koski@gmail.com>"
-license="GPL-3.0-or-later"
+license="GPL-3.0-only"
 homepage="https://github.com/Schniz/fnm"
 changelog="https://raw.githubusercontent.com/Schniz/fnm/master/CHANGELOG.md"
 distfiles="https://github.com/Schniz/fnm/archive/refs/tags/v${version}.tar.gz"
-checksum=df0f010f20e6072a8a52365f195cc94c35ebaf486cc285948e10eabf768d17ba
+checksum=56a170304ab281439a71e541c4db878848c3a891078ae3c2dcc84017cd0306b4
 
 post_install() {
 	for shell in bash fish zsh; do

I'm not very sure whether node.js has builds for all those archs. You may also need to expose a few environment variables as I said in Schniz/fnm#694 (comment) or patch them during build time for musl (but I have no idea if xbps can do that, i.e. run patch only on musl builds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants