Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Webcord-4.8.0 #49731

Closed
wants to merge 1 commit into from
Closed

Conversation

end3r-man
Copy link

@end3r-man end3r-man commented Apr 6, 2024

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@end3r-man
Copy link
Author

any update on my PR??

@meator
Copy link
Contributor

meator commented Apr 6, 2024

Shell globs must be properly quoted.

Every use of ${wrksrc} in your template is unnecessary.

Taking the program directly from a .deb file should be avoided. Such packages do not meet the Compiled package requirement. Properly building the thing should be preferred.

@end3r-man
Copy link
Author

Shell globs must be properly quoted.

Every use of ${wrksrc} in your template is unnecessary.

Taking the program directly from a .deb file should be avoided. Such packages do not meet the Compiled package requirement. Properly building the thing should be preferred.

then getting binary from .deb should be avoided. then only way is getting binary is directly or build from source right??

@cinerea0 cinerea0 added electron 🤮 Electron package request new-package This PR adds a new package labels Apr 6, 2024
@Bnyro
Copy link
Contributor

Bnyro commented Apr 6, 2024

then getting binary from .deb should be avoided. then only way is getting binary is directly or build from source right??

The only way to get this package merged by any chance is to build it from source, yes. Binaries won't be accepted, given the fact that it's an electron app chances it'll be accepted are low anyways.

@end3r-man end3r-man closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron 🤮 Electron package request new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants