Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quazip: update to 1.4 #49782

Closed
wants to merge 4 commits into from
Closed

quazip: update to 1.4 #49782

wants to merge 4 commits into from

Conversation

ElHereward
Copy link
Contributor

@ElHereward ElHereward commented Apr 10, 2024

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture x86_64

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common/shlibs needs to be updated for the new version, and every package that uses quazip needs to be rebuilt (xrevshlib quazip | xargs xrevbump 'rebuild for quazip 1.4'):

--- a/common/shlibs
+++ b/common/shlibs
@@ -2246,7 +2246,7 @@ libtelepathy-qt5-farstream.so.0 telepathy-qt5-farstream-0.9.5_1
 libKF5Attica.so.5 attica-5.6.0_1
 liblastfm_fingerprint5.so.1 liblastfm-qt5-1.0.9_1
 liblastfm5.so.1 liblastfm-qt5-1.0.9_1
-libquazip5.so.1 quazip-0.7.3_2
+libquazip1-qt5.so.1.4.0 quazip-1.4_1
 libjreen-qt5.so.1 jreen-1.3.0_1
 libzen.so.0 libzen-0.4.31_1
 libmediainfo.so.0 libmediainfo-0.7.75_1

srcpkgs/quazip/template Show resolved Hide resolved
@ElHereward
Copy link
Contributor Author

ElHereward commented Apr 11, 2024

@classabbyamp tx - the problem with vmove i could solve.
i changed the shlib template - but i dont understand what you mean by rebuild. Can i test it on my own?
What i also didnt understand: why void packages quazip 0.8.1 but shlibs need 0.7.3? Is there any dependencies at the running system?

@classabbyamp
Copy link
Member

i dont understand what you mean by rebuild

when the version of a shared library changes, the packages that use that shared library need to be rebuilt for the new version

Can i test it on my own?

sure, but those packages also need to be included in this PR with the revision incremented

why void packages quazip 0.8.1 but shlibs need 0.7.3?

common/shlibs records the minimum version of the package that provides the shared library

@ElHereward
Copy link
Contributor Author

i dont understand what you mean by rebuild

when the version of a shared library changes, the packages that use that shared library need to be rebuilt for the new version

Can i test it on my own?

sure, but those packages also need to be included in this PR with the revision incremented

why void packages quazip 0.8.1 but shlibs need 0.7.3?

common/shlibs records the minimum version of the package that provides the shared library

okay tx - then i need to read the docs twice :D

classabbyamp added a commit to classabbyamp/void-packages that referenced this pull request May 13, 2024
classabbyamp added a commit to classabbyamp/void-packages that referenced this pull request May 14, 2024
uggwar pushed a commit to uggwar/void-packages that referenced this pull request May 16, 2024
klliio pushed a commit to klliio/void-packages that referenced this pull request May 21, 2024
OliveThePuffin pushed a commit to OliveThePuffin/void-packages that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants