TheForceEngine: remove optional dependency zenity #49933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zenity is not a required runtime dependency, it's an optional runtime dependency and one of 4 possible that allows file selection dialogs to be shown. This is clear in both the documentation and the source (https://github.com/luciusDXL/TheForceEngine/blob/master/TheForceEngine/TFE_Ui/portable-file-dialogs.h#L525). It also reduces the package size from 120MB (and including weird stuff like webkit and AppStream) to 16MB. Without zenity or kdialog the user has to enter the paths manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing