New package: LACT-0.5.4 #50027
Open
New package: LACT-0.5.4 #50027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calandracas606
commented
Apr 25, 2024
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
| exec 2>&1 | |||
| exec chpst -n -10 lact daemon | |||
There was a problem hiding this comment.
use a nice value of -10 because that is what's used in the sample systemd service
Comment on lines
+9
to
+14
| - // Eagerly release memory | ||
| - // `load_controllers` allocates and deallocates the entire PCI ID database, | ||
| - // this tells the os to release it right away, lowering measured memory usage (the actual usage is low regardless as it was already deallocated) | ||
| - unsafe { | ||
| - libc::malloc_trim(0); | ||
| - } |
There was a problem hiding this comment.
musl does not have malloc_trim
There was a problem hiding this comment.
It might be worth considering applying this patch only on musl and leaving the code intact on glibc.
| pkgname=LACT | ||
| version=0.5.4 | ||
| revision=1 | ||
| archs="x86_64* aarch64*" |
There was a problem hiding this comment.
Uses an AMDGPU cargo crate which only compiles on 64bit
Don't think this matters, since using a modern amd gpu on 32bit arm seems extemely unlikely, but not working on i686 is unfortuneate.
Calandracas606
force-pushed
the
LACT-new
branch
from
85c963f
to
a8cc22d
Compare
Calandracas606
force-pushed
the
LACT-new
branch
from
a8cc22d
to
cf8f2cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package
Local build testing