Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-mpv-1.0.6_1 #50099

Merged
merged 1 commit into from May 2, 2024
Merged

python3-mpv-1.0.6_1 #50099

merged 1 commit into from May 2, 2024

Conversation

kshade
Copy link
Contributor

@kshade kshade commented Apr 28, 2024

Testing the changes

  • I tested the changes in this PR: briefly

build_style=python3-pep517
# this test takes too long and has a low chance of failure
# https://github.com/jaseg/python-mpv/issues/209#issuecomment-1180248112
make_check_args="--deselect tests/test_mpv.py::TestLifecycle::test_wait_for_prooperty_event_overflow"
make_check_args="-v --deselect tests/test_mpv.py::TestLifecycle::test_wait_for_property_event_overflow"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it mandatory that tests be run in verbose mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package appears to have issues with at least one test hanging and never finishing, without verbose it's difficult to determine which one it is since it only outputs periods, one for each finished test. Is that enough to justify enabling the flag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's sufficient to justify enabling verbose mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you!

@cinerea0
Copy link
Contributor

cinerea0 commented May 1, 2024

Your commit message should be something like "python3-mpv: update to 1.0.6", please see "Committing your changes" in CONTRIBUTING.md for more details.

@kshade
Copy link
Contributor Author

kshade commented May 1, 2024

Your commit message should be something like "python3-mpv: update to 1.0.6", please see "Committing your changes" in CONTRIBUTING.md for more details.

Will amend the the commit after a decision about running test in verbose is made.

@cinerea0 cinerea0 merged commit 7791f49 into void-linux:master May 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants