Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab: update to 4.1.8 #50105

Merged
merged 16 commits into from
May 22, 2024
Merged

jupyterlab: update to 4.1.8 #50105

merged 16 commits into from
May 22, 2024

Conversation

tornaria
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

@tornaria
Copy link
Contributor Author

I made this draft for no reason, it's just that I don't know how often to update all the jupyter packages.

There's a jupyterlab 4.2.0rc0, maybe I should update to that one and wait until 4.2.0 is released to bump this?

@dkwo any thoughts?

@dkwo
Copy link
Contributor

dkwo commented May 5, 2024

Thanks for the updates. I didn't test thoroughly yet, but either way is fine with me.
I was waiting for jupyterlab to support server-side handling of cells, such that you can reconnect and do not lose the output, and it seems progress has been made, but not yet ready, so no urgency on my end.

@tornaria
Copy link
Contributor Author

tornaria commented May 5, 2024

Thanks for the updates. I didn't test thoroughly yet, but either way is fine with me. I was waiting for jupyterlab to support server-side handling of cells, such that you can reconnect and do not lose the output, and it seems progress has been made, but not yet ready, so no urgency on my end.

Let's wait until jupyterlab 4.2.0. Will that include the feature you want?

@tornaria
Copy link
Contributor Author

tornaria commented May 7, 2024

jupyterlab 4.2.0 is out, but it seems to need nodejs 20. A lot of tests fail and they all complain about nodejs version.

Hence, let's push this for now.

@tornaria tornaria marked this pull request as ready for review May 7, 2024 16:11
@dkwo
Copy link
Contributor

dkwo commented May 7, 2024

Sounds good.
I think it's possbile with 4.2.0 but it requires jupyter-collaboration >=2.0 and jupyverse >=0.4.0,
if I understand jupyterlab/jupyterlab#15448
Let's revisit this later.

@cinerea0 cinerea0 merged commit 480e408 into void-linux:master May 22, 2024
8 checks passed
@tornaria tornaria deleted the jupyter branch May 22, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants