Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runit-void: fix issue with fsck on mounted partitions #50192

Merged
merged 1 commit into from
May 5, 2024

Conversation

classabbyamp
Copy link
Member

@classabbyamp classabbyamp commented May 4, 2024

see #50124

backport of void-linux/void-runit#115

Testing the changes

  • I tested the changes in this PR: YES

@dkwo can you test this?

@classabbyamp classabbyamp force-pushed the blkdev-write-mounted branch 3 times, most recently from accb708 to fd2a6b8 Compare May 5, 2024 12:26
@dkwo
Copy link
Contributor

dkwo commented May 5, 2024

With bdev_allow_write_mounted=true, the behavior is as before.
Without it, it prints the same message

fsck.ext4: Device or resource busy while trying to open /dev/mapper/cryptroot-root
Filesystem mounted or opened exclusively by another program?

and then it continues (without fsck-ing other partitions like /boot).
So this seems to work as expected in my simple setup.

@dkwo
Copy link
Contributor

dkwo commented May 5, 2024

I wonder if this fsck checks should rather run in the initramfs, before mounting anything.

@classabbyamp
Copy link
Member Author

with mkinitcpio, fsck is run in the initramfs, idk about dracut

@classabbyamp classabbyamp merged commit 92a5a84 into void-linux:master May 5, 2024
8 checks passed
@classabbyamp classabbyamp deleted the blkdev-write-mounted branch May 5, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants