New package: zk-0.14.0 #50400
Merged
New package: zk-0.14.0 #50400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cinerea0 Be advised that this package downloads tons of dependencies off Github none of which are checksumed... They probably need to be pre-downloaded. |
|
that's how go works... and they are checksummed |
|
Ah, nice about the checksums, I didn't really look... We can still pre-download the packages in case we don't trust the Go infrastructure to properly verify them. |
|
we're not going to do that all 380 go packages... |
|
It's about 40, the file includes older versions but yeah, a bit on the populous side here... |
|
I meant all the other packages that do the exact same thing because this is how go's build system works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package
Unfortunately they haven't made a new release since switching to the new org, so the
go_import_pathwill be weird until the next release.Closes #50398