curl: update to 8.8.0 #50463
Merged
curl: update to 8.8.0 #50463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgn
reviewed
May 22, 2024
| @@ -43,6 +43,9 @@ pre_configure() { | |||
| export CFLAGS="${CFLAGS/-D_FORTIFY_SOURCE=2/}" | |||
| export CFLAGS="${CFLAGS/-I${XBPS_CROSS_BASE}\/usr\/include/}" | |||
| export CPPFLAGS="-D_FORTIFY_SOURCE=2" | |||
|
|
|||
| # reconfigure for patched changes | |||
| autoreconf -fi | |||
There was a problem hiding this comment.
Just make man and do install manually!
There was a problem hiding this comment.
or we switch to the cmake build?
There was a problem hiding this comment.
doing autoreconf felt less invasive to me, as for cmake - I'm not sure what the benefit is when the autotools config is tried and true at this point
There was a problem hiding this comment.
Looking into cmake, it's not yet ready for daily use:
# TODO: # The output .so file lacks the soname number which we currently have within the lib/Makefile.am file
There was a problem hiding this comment.
I merge as is. The resulting package is the very same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes