Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-ares: Update to 1.30.0, apply new download link #50739

Closed

Conversation

techflashYT
Copy link
Contributor

@techflashYT techflashYT commented Jun 7, 2024

c-ares' new version is 1.30.0, and the current 1.29.0 doesn't build due to a now-missing download link. Fix both problems at once to get the package building again.

I've tested these changes on several architectures for glibc and musl.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • (cross) i686
    • (cross) i686-musl
    • (cross) mips-musl
    • (cross) ppc
    • ppc
    • (cross) armv6l-musl
    • (cross) armv6l
    • (cross) aarch64-musl
    • (cross) aarch64

c-ares' new version is 1.30.0, and the current 1.29.0 doesn't build due to a missing download link.
Fix both problems at once to get the package building again.
@techflashYT
Copy link
Contributor Author

Edit: forgot to mark crossbuilds like the note said, fixed.

Comment on lines 10 to 11
homepage="https://c-ares.haxx.se/"
changelog="https://c-ares.haxx.se/changelog.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage="https://c-ares.haxx.se/"
changelog="https://c-ares.haxx.se/changelog.html"
homepage="https://c-ares.org"
changelog="https://c-ares.org/changelog.html"

@classabbyamp
Copy link
Member

commit message should be only c-ares: update to 1.30.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants