Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: remove deprecated --unity-launch flag from desktop file #50762

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

deimonn
Copy link
Contributor

@deimonn deimonn commented Jun 10, 2024

VSCode has deprecated the --unity-launch flag and its presence was breaking the "Open with Code" context menu option.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

Closes #50682

@classabbyamp
Copy link
Member

should this use --new-window?

@deimonn
Copy link
Contributor Author

deimonn commented Jun 10, 2024

Someone else already suggested that on this arch package issue, and the response was that it may be undesirable, as it "[...] makes Visual Studio open a new window each time a file is opened, irrespective of the folder the files are placed in".

I've been using it without --unity-launch and without --new-window and so far I haven't detected any strange behavior.

@classabbyamp classabbyamp merged commit f119e3e into void-linux:master Jun 11, 2024
8 checks passed
@deimonn deimonn deleted the vscode branch June 13, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode: "Open with..." action opens vscode with no workspace
3 participants