Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vanitygen: update to 0.22. #5690

Merged
merged 1 commit into from
Jan 18, 2019
Merged

vanitygen: update to 0.22. #5690

merged 1 commit into from
Jan 18, 2019

Conversation

Chocimier
Copy link
Member

No description provided.

@maxice8
Copy link
Contributor

maxice8 commented Dec 11, 2018

needs samr7/vanitygen#104

@maxice8
Copy link
Contributor

maxice8 commented Jan 12, 2019

please rebase your changes on top of master

@Chocimier
Copy link
Member Author

rebased

@Hoshpak
Copy link
Member

Hoshpak commented Jan 17, 2019

Do we really need to wait for a dead upstream project to tag before merging? I understand the reason for not packaging random git revisions but in this case the commit has been declared by upstream as an release (although not by adding a tag) and we have a tarball which can be cached. I would be inclined to just merge as is.

Btw, does AGPL really need vlicense?

@maxice8
Copy link
Contributor

maxice8 commented Jan 17, 2019 via email

Copy link
Contributor

@maxice8 maxice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hoshpak Hoshpak merged commit 149409c into void-linux:master Jan 18, 2019
@Chocimier Chocimier deleted the vanitygen branch February 2, 2019 12:40
@ARTEMKA-STOM
Copy link

5md--sha

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants