cross-arm-none-eabi : Use exactly the same build recipe as the offici… #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teajay-fr
force-pushed
the
gcc-arm-none-eabi
branch
from
1046d31
to
f293d3e
Compare
…al arm toolchain With this patch, the void build of the arm embedded processor cross matches the same version as the currently official gcc version 7.3.1. The arm provided patches are applied and the build recipes match. This fixes issue 4931 and 1824
teajay-fr
force-pushed
the
gcc-arm-none-eabi
branch
from
f293d3e
to
1f6dbc0
Compare
This was referenced Jan 2, 2019
|
Vendoring a massive patch like this one is not really an option. |
|
Well I could rework the build to use the tar package provided by arm. That would avoid the patch. The outcome should be the same. |
|
Yes, this would be better. Is there a reason why this patch isn't upstream? |
|
There are some parts that come upstream but I don't know exactly why arm and the gcc team choose to go this way. As far as I understand arm provides a specific distribution of gcc which follows the gcc developments. I'm not into the details so I can't say much more. I'll look into eliminating the required patch and build the toolchain from the arm provided package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…al arm toolchain
With this patch, the void build of the arm embedded processor cross
matches the same version as the currently official gcc version 7.3.1.
The arm provided patches are applied and the build recipes match.
This fixes issue 4931 and 1824