Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alacritty: remove soft dependency xclip #8586

Closed
wants to merge 1 commit into from

Conversation

svenper
Copy link
Contributor

@svenper svenper commented Feb 12, 2019

Since 0.2.8, if xclip is missing when copying/pasting text, alacritty displays an explicit warning about this.

Since 0.2.8, if `xclip` is missing when copying/pasting text, `alacritty` displays an explicit warning about this.
@jnbr
Copy link
Contributor

jnbr commented Feb 12, 2019

Why shouldn't we depend on it in the first place?

@svenper
Copy link
Contributor Author

svenper commented Feb 12, 2019

@jnbr If alacritty depends on xclip, it will change the behavior of other programs having xclip as a soft dependency as well, e.g. neovim. In this case it is easy to provide user choice.

@maxice8
Copy link
Contributor

maxice8 commented Feb 18, 2019

xclip is a "soft" dependency for a very important feature (copy-pasting) on the most used graphical server (Xorg)

@Gottox
Copy link
Member

Gottox commented Feb 18, 2019

The upstream bug: alacritty/alacritty#5

Copy link
Contributor

@maxice8 maxice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, part of important functionality

@Gottox
Copy link
Member

Gottox commented Feb 21, 2019

Closing. Ultimatively, this bug needs to be fixed upstream.

@Gottox Gottox closed this Feb 21, 2019
@svenper svenper deleted the patch-1 branch February 21, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants