This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
[ci skip] Unset CONFIG_ADB_PMU_LED_DISK for ppc. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbrown101
pushed a commit
to adbrown101/void-packages
that referenced
this pull request
Apr 12, 2021
Programmierschmied
pushed a commit
to Programmierschmied/void-packages
that referenced
this pull request
Apr 13, 2021
hazayan
pushed a commit
to hazayan/void-packages
that referenced
this pull request
Apr 15, 2021
atweiden
added a commit
to atweiden/voidpkgs
that referenced
this pull request
Apr 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
Why am I making this change? There is a LED driver that is using this config:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/macintosh/via-pmu-led.c
It is exposed as
/sys/class/leds/pmu-led:front. If CONFIG_ADB_PMU_LED_DISK is yes then the value of trigger will be "disk-activity" otherwise it will be "none" (the value can be overwritten by writing to /sys/class/leds/pmu-led:front/trigger after boot). I think "none" is a better default because the LED is not used as a disk activity indicator in Mac OS, rather it would pulse slowly when the notebook is in sleep mode. The LED is a bit too bright as a disk activity indicator, someone made a video showing this:https://youtu.be/cbmnuUc-G6c?t=55
( The video was made using a different Linux distro but void ppc would behave the same wrt the LDE.)
For reference, Ubuntu, which used to ship a PowerPC version, is not enabling CONFIG_ADB_PMU_LED_DISK (formerly CONFIG_ADB_PMU_LED_IDE). I can find out more config choices from other distributions, if needed.
Should we change ppc64 as well? I don't know at this point. Note that in the code it appears that only PowerMac7,2 and PowerMac7,3 are allowed to drive the LED.