Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust "non-existent" URLs in tests #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adjust "non-existent" URLs in tests #18

wants to merge 1 commit into from

Conversation

khitrenovich
Copy link

Looks like somebody registered "adadadadad.com", which causes unit tests to fail.

Ideally, packages like nock should be used in such cases, but this works as a quick fix.

@khitrenovich khitrenovich mentioned this pull request Feb 25, 2020
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 51

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.3%) to 98.81%
Totals Coverage Status
Change from base Build 47: 8.3%
Covered Lines: 54
Relevant Lines: 54
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khitrenovich @coveralls