Skip to content

Commit

Permalink
regulator: Resolve section mismatches
Browse files Browse the repository at this point in the history
Some SODP devices (e.g. seine), would fail to build with similar,
straightforward warnings:

WARNING: vmlinux.o(___ksymtab+regulator_stub_init+0x0): Section mismatch in
reference from the variable __ksymtab_regulator_stub_init to the function
.init.text:regulator_stub_init() The symbol regulator_stub_init is exported
and annotated __init Fix this by removing the __init annotation of
regulator_stub_init or drop the export.

Follow the instructions provided by the failing builds to allow it to
finish.

Signed-off-by: voidanix <voidanix@keyedlimepie.org>
  • Loading branch information
voidanix committed Mar 17, 2024
1 parent 7c627cf commit 076ef95
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion drivers/regulator/qpnp-regulator.c
Expand Up @@ -2574,7 +2574,6 @@ int __init qpnp_regulator_init(void)

return platform_driver_register(&qpnp_regulator_driver);
}
EXPORT_SYMBOL(qpnp_regulator_init);

static void __exit qpnp_regulator_exit(void)
{
Expand Down
3 changes: 1 addition & 2 deletions drivers/regulator/rpm-smd-regulator.c
Expand Up @@ -2042,7 +2042,7 @@ static struct platform_driver rpm_vreg_resource_driver = {
*
* Returns 0 on success or errno on failure.
*/
int __init rpm_smd_regulator_driver_init(void)
static int __init rpm_smd_regulator_driver_init(void)
{
static bool initialized;
int i, rc;
Expand All @@ -2065,7 +2065,6 @@ int __init rpm_smd_regulator_driver_init(void)
initialized = true;
return 0;
}
EXPORT_SYMBOL(rpm_smd_regulator_driver_init);

static void __exit rpm_vreg_exit(void)
{
Expand Down
1 change: 0 additions & 1 deletion drivers/regulator/stub-regulator.c
Expand Up @@ -293,7 +293,6 @@ int __init regulator_stub_init(void)

return platform_driver_register(&regulator_stub_driver);
}
EXPORT_SYMBOL(regulator_stub_init);
postcore_initcall(regulator_stub_init);

static void __exit regulator_stub_exit(void)
Expand Down
4 changes: 0 additions & 4 deletions include/linux/regulator/rpm-smd-regulator.h
Expand Up @@ -106,8 +106,6 @@ int rpm_regulator_set_voltage(struct rpm_regulator *regulator, int min_uV,
int rpm_regulator_set_mode(struct rpm_regulator *regulator,
enum rpm_regulator_mode mode);

int __init rpm_smd_regulator_driver_init(void);

#else

static inline struct rpm_regulator *rpm_regulator_get(struct device *dev,
Expand All @@ -127,8 +125,6 @@ static inline int rpm_regulator_set_voltage(struct rpm_regulator *regulator,
static inline int rpm_regulator_set_mode(struct rpm_regulator *regulator,
enum rpm_regulator_mode mode) { return 0; }

static inline int __init rpm_smd_regulator_driver_init(void) { return 0; }

#endif /* CONFIG_REGULATOR_RPM_SMD */

#endif

0 comments on commit 076ef95

Please sign in to comment.