Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizers Page #49

Open
Caballerog opened this issue Jun 23, 2020 · 4 comments
Open

Organizers Page #49

Caballerog opened this issue Jun 23, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@Caballerog
Copy link
Member

Is your feature request related to a problem? Please describe.
Add more details about Organizers.

Describe the solution you'd like
We could show more information about each organizer, i.e. a page in which you can find information about each organizer (using a search).

@Caballerog Caballerog added the enhancement New feature or request label Jun 23, 2020
@Caballerog Caballerog added this to the 1.0 milestone Jun 23, 2020
@Caballerog Caballerog self-assigned this Jun 23, 2020
@Caballerog Caballerog added the good first issue Good for newcomers label Jun 24, 2020
@SergioTribaldos
Copy link

Any more information on this issue? I want to pick up this one, but I don´t know what is exactly the idea

@NyaGarcia
Copy link
Member

The idea would be to add an organizer-detail component, which would contain information about the community organizers, e.g:

  • Full name
  • Job position
  • Biography
  • Social media links
  • Any other links (e.g. link to portfolio, company page etc.)

The organizer names that appear in each community would be links that direct to the organizer-detail component, passing the clicked organizer id so that the component displays the correct organizer information.

In order to implement this, it would be necessary to add an organizer service, containing the necessary methods to obtain the organizer information, which would have to be contained in an organizers.json separate from the communities.json It would be interesting to implement storage for the organizers in Firebase (@Anexon what do you think?), so that we can remove the communities.json from the client.

If you have any questions on how to implement this, or any suggestions, please let me know :D

@SergioTribaldos
Copy link

Nice, so that info would be displayed in the right sidenav keeping the map visible or displaying a new component? Also a modal popup could be an option. WDYT?

@Anexon
Copy link

Anexon commented Jun 26, 2020

@NyaGarcia it would be exactly like that.
In the PR #55 data structure is like this:
Captura de pantalla 2020-06-26 a las 19 16 04

So keeping track of a community ID would be enough. In the mean time this featured is finished full info of the community may be passed to the Community Detail Component, then it can be changed to a service.

Regarding to using a different file, I would say that the easiest way would keep all the detail info under the same file, but there is no problem on splitting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants