Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MB to GB #12

Closed
deadcoder0904 opened this issue Aug 15, 2019 · 9 comments
Closed

Convert MB to GB #12

deadcoder0904 opened this issue Aug 15, 2019 · 9 comments
Assignees
Labels
done Finished working on the issue
Projects

Comments

@deadcoder0904
Copy link

1335 MB is not that helpful. GB conversion is more helpful I think since people are more used to GB if it exceeds over 1023 MB :)

@Caballerog
Copy link
Member

It would be great!

@zaldih
Copy link
Member

zaldih commented Aug 15, 2019

Hi there! Thanks for opening the issue.
At the beginning we decided to show the sizes in the same unit so that it would be easy to compare them, since rarely a single node_modules would weigh more than 1023 mb.

But I think, as you say, it is a good idea that in the total space (releasable space and space saved) are those shown in GB.

We are also thinking of adding a parameter to change the units

A greeting!

@deadcoder0904
Copy link
Author

I think it would be great even for single node_modules because if you have big projects like https://github.com/devhubapp/devhub then it exceeds over 1023MB easily :)

@zaldih zaldih added this to To do next release in npkill main Aug 15, 2019
@mikeerickson
Copy link

How about showing both

nnnn mb / yyyy gb

@deadcoder0904
Copy link
Author

@mikeerickson I think it's a bit overkill. The reason I said GB is because it's more readable. Idk who wants to know both conversions 1GB (1024MB) looks a bit weird to me at least 😂

@mikeerickson
Copy link

@deadcoder0904 just offering a suggestion to appease to both sides

@NyaGarcia NyaGarcia added the in progress Working on resolving the issue label Aug 16, 2019
@zaldih
Copy link
Member

zaldih commented Aug 16, 2019

working at #18

@zaldih zaldih moved this from To do next release to In progress in npkill main Aug 16, 2019
@zaldih zaldih moved this from In progress to Done in npkill main Aug 17, 2019
@NyaGarcia NyaGarcia added done Finished working on the issue and removed in progress Working on resolving the issue labels Aug 18, 2019
@NyaGarcia
Copy link
Member

Just published a release that includes this feature :)

@deadcoder0904
Copy link
Author

Thank you that looks amazing 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Finished working on the issue
Projects
npkill main
  
Done
Development

No branches or pull requests

5 participants