Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile email rendering, drop all paddings on vertical screens #20

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

codingjoe
Copy link
Member

@codingjoe codingjoe commented Mar 29, 2023

The style-tag was scrapping the styles block, which was misleading. Template blocks should probably wrap DOM not CSS, especially with the naming. @amureki you actually used it wrong in one project.

I also used a zero-width space, or zero byte char, instead of the space, to enable paddings on Outlook.

The vertical padding is gone, on vertical phones, since most email clients implement their own padding. We cannot drop the padding completly thanks to Mail on iOS, but we increased it to match iOS and look more deliberate in Gmail.

@codingjoe codingjoe self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ad3722c) 100.00% compared to head (b7e650b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          172       172           
=========================================
  Hits           172       172           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe
Copy link
Member Author

@mostafa-anm I double-checked Outlook and Gmail.

@codingjoe codingjoe merged commit d146b02 into main Mar 29, 2023
@codingjoe codingjoe deleted the mobile branch March 29, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants