Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outputs DOM structure #74

Merged
merged 9 commits into from
May 3, 2023
Merged

Fix outputs DOM structure #74

merged 9 commits into from
May 3, 2023

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented May 3, 2023 •
edited
Loading

References

Another step for resolving #70. It does not look exactly the same as classic Voila still, but it's already better.

Code changes

We were missing the collapser and the SimplifiedAreaOutput was missing some DOM elements.

@martinRenou martinRenou added the enhancement New feature or request label May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

lite-badge 👈 Try it on ReadTheDocs

@martinRenou martinRenou marked this pull request as draft May 3, 2023 11:02
@martinRenou martinRenou marked this pull request as ready for review May 3, 2023 11:34
@martinRenou
Copy link
Member Author

Thanks!

@martinRenou martinRenou merged commit 3af43da into voila-dashboards:main May 3, 2023
4 checks passed
@martinRenou martinRenou deleted the fix_output_dom_structure branch May 3, 2023 11:34
@martinRenou martinRenou mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinRenou @trungleduc