0.3.x: Fix OpenSSL issue (#1337)

* Fix OpenSSL issue * OpenSSL issue in labextension * Remove openssl pinning * Iterate * Wut * Fix ui-test env * Linter * Iterate
voila-dashboards · Jun 23, 2023 · 3dd92da · 3dd92da
1 parent c736653
commit 3dd92da
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,7 +28,7 @@ jobs:
 
     - name: Create the conda environment
       shell: bash -l {0}
-      run: mamba install -q python=${{ matrix.python_version }} pip jupyterlab_pygments==0.1.0 pytest-cov pytest-rerunfailures nodejs==16.19.0 yarn==1 flake8 ipywidgets matplotlib xeus-cling openssl=1.1.1l "traitlets>=5.0.3,<6"
+      run: mamba install -q python=3.9 pip jupyterlab_pygments=0.1.0 pytest-cov pytest-rerunfailures nodejs=16.19.0 yarn=1 flake8 ipywidgets matplotlib xeus-cling traitlets=5
 
     - name: Install Dependencies
       shell: bash -l {0}

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -32,7 +32,7 @@ jobs:
 
     - name: Create the conda environment
       shell: bash -l {0}
-      run: mamba install -q python=${{ matrix.python_version }} pip jupyterlab_pygments==0.1.0 pytest-cov pytest-rerunfailures nodejs==16.19.0 yarn==1 flake8 ipywidgets matplotlib xeus-cling openssl=1.1.1l "traitlets>=5.0.3,<6"
+      run: mamba install -q python=${{ matrix.python_version }} pip jupyterlab_pygments=0.1.0 pytest-cov pytest-rerunfailures nodejs=16 yarn=1 flake8 ipywidgets matplotlib xeus-cling traitlets=5
 
     - name: Install dependencies
       shell: bash -l {0}
@@ -82,7 +82,7 @@ jobs:
 
     - name: Create the conda environment
       shell: bash -l {0}
-      run: mamba install -q python=${{ matrix.python_version }} pip jupyterlab_pygments==0.1.0 pytest-cov pytest-rerunfailures nodejs yarn flake8 ipywidgets matplotlib xeus-cling openssl=1.1.1l "traitlets>=5.0.3,<6"
+      run: mamba install -q python=${{ matrix.python_version }} pip jupyterlab_pygments=0.1.0 pytest-cov pytest-rerunfailures nodejs=16 yarn=1 flake8 ipywidgets matplotlib xeus-cling traitlets=5
 
     - name: Install dependencies
       shell: bash -l {0}

diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml
@@ -2,6 +2,10 @@ name: UI Tests
 
 on: [push, pull_request]
 
+defaults:
+  run:
+    shell: bash -l {0}
+
 jobs:
   ui-tests:
     name: Visual Regression
@@ -17,6 +21,15 @@ jobs:
       - name: Base Setup
         uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
 
+      - name: Setup mamba
+        uses: conda-incubator/setup-miniconda@v2
+        with:
+          mamba-version: "*"
+          channels: conda-forge
+
+      - name: Create the conda environment
+        run: mamba install -q python=3.9 pip jupyterlab_pygments=0.1.0 pytest-cov pytest-rerunfailures nodejs=16.19.0 yarn=1 flake8 ipywidgets matplotlib xeus-cling traitlets=5
+
       - name: Install dependencies
         run: |
           python -m pip install --upgrade ".[test,visual_test]"

diff --git a/packages/jupyterlab-preview/package.json b/packages/jupyterlab-preview/package.json
@@ -72,6 +72,7 @@
   },
   "jupyterlab": {
     "extension": true,
+    "webpackConfig": "webpack.lab.config.js",
     "schemaDir": "schema",
     "outputDir": "../../voila/labextension",
     "discovery": {

diff --git a/packages/jupyterlab-preview/webpack.lab.config.js b/packages/jupyterlab-preview/webpack.lab.config.js
@@ -0,0 +1,6 @@
+const crypto = require('crypto');
+
+// Workaround for loaders using "md4" by default, which is not supported in FIPS-compliant OpenSSL
+const cryptoOrigCreateHash = crypto.createHash;
+crypto.createHash = algorithm =>
+  cryptoOrigCreateHash(algorithm === 'md4' ? 'sha256' : algorithm);
diff --git a/packages/voila/webpack.config.js b/packages/voila/webpack.config.js
@@ -1,5 +1,12 @@
 var path = require('path');
 
+const crypto = require('crypto');
+
+// Workaround for loaders using "md4" by default, which is not supported in FIPS-compliant OpenSSL
+const cryptoOrigCreateHash = crypto.createHash;
+crypto.createHash = algorithm =>
+  cryptoOrigCreateHash(algorithm === 'md4' ? 'sha256' : algorithm);
+
 var rules = [
   { test: /\.css$/, use: ['style-loader', 'css-loader'] },
   // required to load font-awesome