Wrap context.save inside try-catch block (#1181)

voila-dashboards · Aug 31, 2022 · c9c6db5 · c9c6db5
1 parent 249b077
commit c9c6db5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/packages/jupyterlab-preview/src/index.ts b/packages/jupyterlab-preview/src/index.ts
@@ -183,8 +183,11 @@ const extension: JupyterFrontEndPlugin<IVoilaPreviewTracker> = {
         let context: DocumentRegistry.IContext<INotebookModel>;
         if (current) {
           context = current.context;
-          await context.save();
-
+          try {
+            await context.save();
+          } catch (e) {
+            console.error(e);
+          }
           commands.execute('docmanager:open', {
             path: context.path,
             factory: 'Voila-preview',
@@ -204,7 +207,11 @@ const extension: JupyterFrontEndPlugin<IVoilaPreviewTracker> = {
         if (!current) {
           return;
         }
-        await current.context.save();
+        try {
+          await current.context.save();
+        } catch (e) {
+          console.error(e);
+        }
         const voilaUrl = getVoilaUrl(current.context.path);
         window.open(voilaUrl);
       },

diff --git a/packages/jupyterlab-preview/src/preview.tsx b/packages/jupyterlab-preview/src/preview.tsx
@@ -98,7 +98,11 @@ export class VoilaPreview extends DocumentWidget<IFrame, INotebookModel> {
       icon: refreshIcon,
       tooltip: 'Reload Preview',
       onClick: async () => {
-        await context.save();
+        try {
+          await context.save();
+        } catch (e) {
+          console.error(e);
+        }
         this.reload();
       }
     });