-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel not shut down on page reload in Firefox #528
Comments
Does the network page of the developertools reveal any special caching? |
Investigating this further. It looks like the cache is not involved, but instead it might be related to Adblock. With Adblock enabled, the shutdown request doesn't show up in the network logs: And with Adblock disabled, the shutdown request ( With Chrome, the |
Moreover, the request doesn't show up in the Adblock tab in the dev tools. This might be because the page is reloaded and the list of blocked requests deleted. Interestingly, whitelisting |
It looks like it can be reproduced by enabling other browser extensions, such as HTTPS Everywhere (and disabling ad-blockers). |
I'm looking into if it makes sense to start a ServiceWorker here for managing shutdown submissions. A short postMessage in |
Or possibly |
|
Even better! Learning every day :) Thanks @vidartf ! |
Good point @jtpio. 🤷 |
Maybe we would then need an extra voila POST endpoint for that specific purpose. Something like |
That would hopefully work, although the endpoint name suggest shutting down the server at the moment 😉 Maybe |
For sure. Although in some way it still sounds like a workaround and a "duplicate" of the existing jupyter server shutdown endpoint? |
It is definitely a workaround and duplicate. It might be that the XHTTP async=false is the best approach, as a DELETE request should not be too slow. The |
At least the |
Reloading the page in Firefox doesn't seem to be shutting the kernel down, while it does in Chrome. It is the same issue as the one mentioned in #55 (comment), but seems to be specific to Firefox at the moment.
Tested with:
The text was updated successfully, but these errors were encountered: