Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the list of voila kernels in the running tabs #611

Closed
wants to merge 5 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 20, 2020

EDIT: this branch depends on #41. The relevant changes for this current PR are the ones under packages/jupyterlab-voila/*.

Motivation

Having such list can be useful to get an idea of the number of kernels that are currently running.

It should also help troubleshoot issues such as #479, #528, #562.

TODO

  • Add a new section to the running tabs
  • Filter the list of kernels to only show the ones started by Voila (for now it lists all the kernels)

preview-list-kernels

@jtpio jtpio added the jupyterlab-preview JupyterLab Preview Extension label May 20, 2020
@jtpio
Copy link
Member Author

jtpio commented May 29, 2020

Just rebased this PR onto #41 so it can use the GET /voila/api/kernels endpoint to list the voila kernels kernels only.

@jtpio
Copy link
Member Author

jtpio commented May 29, 2020

The relevant change for this PR is in 568d7a0 (might be updated on subsequent rebases)

@jtpio jtpio closed this Jul 14, 2020
@jtpio jtpio reopened this Jul 14, 2020
@jtpio
Copy link
Member Author

jtpio commented Jan 23, 2023

This might actually be fixed in JupyterLab directly: jupyterlab/jupyterlab#13792.

@afshin
Copy link
Member

afshin commented Jan 23, 2023

This might actually be fixed in JupyterLab directly: jupyterlab/jupyterlab#13792.

As long as api/kernels returns the kernels in question, then yes!

@jtpio
Copy link
Member Author

jtpio commented Mar 14, 2023

Just checked with jupyterlab==4.0.0a35 and voila==0.5.0a2 and the kernels appear to be listed in the running panel:

image

Closing as fixed by jupyterlab/jupyterlab#13792, thanks @afshin!

@jtpio jtpio closed this Mar 14, 2023
@jtpio jtpio deleted the list-kernels branch March 14, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jupyterlab-preview JupyterLab Preview Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants