Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipywidgets 7.7 incompatibility issue #1121

Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Mar 22, 2022

References

Fix #1119

Code changes

This removes all the widgets fetching logic from Voila and relies on ipywidgets for doing it.

User-facing changes

Voila and ipywidgets 7.7 should now be compatible, fixing some issues when widgets have child widgets.

Note that the Front-end code now builds against the 7.7 widget manager, but this should not have an impact on ipywidgets <7.7 compatibility (tested locally with 7.6)

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/fix_ipywidgets_7.7_issue

@martinRenou martinRenou added bug Something isn't working maintenance and removed bug Something isn't working labels Mar 22, 2022
@martinRenou martinRenou mentioned this pull request Mar 22, 2022
@maartenbreddels
Copy link
Member

Cool, so _loadFromKernel is a new API from the widget manager, then I should check if #1101 is present in that.

@trungleduc
Copy link
Member

Thanks @martinRenou, we need to update some screenshots for the UI test. I do not recall the command for the bot.

@martinRenou
Copy link
Member Author

then I should check if #1101 is present in that.

I guess not, maybe we should upstream that PR to ipywidgets

we need to update some screenshots for the UI test. I do not recall the command for the bot.

Please update galata references

@maartenbreddels
Copy link
Member

I guess not, maybe we should upstream that PR to ipywidgets

yeah, that's what I meant to say

@trungleduc trungleduc closed this Mar 22, 2022
@trungleduc trungleduc reopened this Mar 22, 2022
@trungleduc
Copy link
Member

Restart CI

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 147 <- [171 - 207 - 283] -> 514 93 <- [99 - 114 - 143] -> 212 92 <- [96 - 111 - 135] -> 190 95 <- [104 - 115 - 142] -> 202 2592 <- [2901 - 2953 - 3004] -> 3535 2830 <- [2896 - 3001 - 3106] -> 3460 3236 <- [3257 - 3297 - 3474] -> 3920 3015 <- [3078 - 3080 - 3233] -> 3483 2081 <- [2222 - 2224 - 2224] -> 2250 4528 <- [4569 - 4644 - 4973] -> 5967 8611 <- [10159 - 10641 - 10886] -> 10980 7716 <- [7730 - 7744 - 7836] -> 7897 1804 <- [1910 - 1958 - 2161] -> 2405 2841 <- [2851 - 2884 - 2968] -> 3624
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-03-22 10:13:09.703042679 +0000
+++ /dev/fd/62	2022-03-22 10:13:09.703042679 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8171M",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "4",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7284850688
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.11.0-1028-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.4 LTS",
-      "serial": "6fe698402f044602bf038833560abb94",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc
Copy link
Member

Thanks @martinRenou!

@trungleduc trungleduc merged commit 9b5ba48 into voila-dashboards:main Mar 22, 2022
@martinRenou martinRenou deleted the fix_ipywidgets_7.7_issue branch March 22, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gridspecLayout example does not work with ipywidgets=7.7.0
3 participants