Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing CI #1281

Merged
merged 1 commit into from Feb 8, 2023
Merged

Conversation

jabbera
Copy link
Contributor

@jabbera jabbera commented Feb 8, 2023

References

Fixes CI builds.

Code changes

Force Node 16 for UI Tests: Ref
Use Mambaforge to avoid whatever intermittent issue mamba-version was causing: Ref

User-facing changes

None

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Binder 👈 Launch a Binder on branch jabbera/voila/fix-existing-ci

@jabbera
Copy link
Contributor Author

jabbera commented Feb 8, 2023

I'm looking to add support for jupyter_server>=2 but I really need a stable CI base and test framework to get going. Hope this solves the issue!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 79 <- [83 - 92 - 108] -> 155 82 <- [85 - 96 - 116] -> 160 76 <- [80 - 88 - 105] -> 135 73 <- [75 - 80 - 90] -> 112 3116 <- [3205 - 3272 - 3361] -> 4036 2996 <- [3014 - 3054 - 3128] -> 3137 3008 <- [3083 - 3108 - 3255] -> 3415 2985 <- [3014 - 3100 - 3214] -> 3403 2415 <- [2434 - 2449 - 2459] -> 2680 4011 <- [4080 - 4280 - 4518] -> 5086 5945 <- [5997 - 6039 - 6179] -> 6486 1904 <- [1925 - 1992 - 2033] -> 2112 3083 <- [3095 - 3136 - 3141] -> 3238
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2023-02-08 06:00:31.628037773 +0000
+++ /dev/fd/62	2023-02-08 06:00:31.628037773 +0000
@@ -4,49 +4,49 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
         "l2": 524288,
-        "l3": 52428800
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281278976
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
       "build": "",
-      "codename": "Jammy Jellyfish",
+      "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1031-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "22.04.1 LTS",
-      "serial": "9940bfb4681a4673a4d5a71034418523",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc
Copy link
Member

Thank you a lot @jabbera!

@trungleduc trungleduc merged commit 5a11e82 into voila-dashboards:main Feb 8, 2023
@jabbera
Copy link
Contributor Author

jabbera commented Feb 8, 2023

@trungleduc hope to have more coming.

@martinRenou
Copy link
Member

@meeseeksdev please backport to 0.4.x

meeseeksmachine pushed a commit to meeseeksmachine/voila that referenced this pull request Jun 26, 2023
martinRenou pushed a commit that referenced this pull request Jun 26, 2023
Co-authored-by: Mike <jabbera@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants