Use plural for template(s) data dir #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aschlaep for custom template authors, the consequence is that new template should be installed into |
|
I agree it should be plural now. But I think we may want to have more changes, and I'm not sure we should break the template system twice in a short time. |
|
We are at 0.0.10, I think we can break it now, but not after we release 0.1.0. |
SylvainCorlay
force-pushed
the
template-plural
branch
from
f3391f4
to
b4fcc42
Compare
SylvainCorlay
force-pushed
the
template-plural
branch
from
b4fcc42
to
7be3903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the
tiebreakerfor this discussion is the case of Jupyter kernels, which is plural.