Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't 500 on cell execution errors #186

Merged
merged 1 commit into from Jun 5, 2019

Conversation

ivanov
Copy link
Contributor

@ivanov ivanov commented Jun 5, 2019

Sometimes, code execution will error (for example, missing dependencies), and it's rough to get 500 errors in the browser and have to look in the console where the server was started to see what the error was. This code leaves in-place the error presented in the notebook when executing that particular cell, and continues to log in on the server-side, but without causing a server 500 error.

@SylvainCorlay
Copy link
Member

I recall that the nbexecute preprocessor had some options to allow continuation of execution if a cell fails.

I wonder how this could work with this.

@maartenbreddels maartenbreddels merged commit 3d3623b into voila-dashboards:master Jun 5, 2019
@vidartf
Copy link
Contributor

vidartf commented Jun 5, 2019

If the cell has a tag raises-exception (or something like that) it will allow any exceptions to pass, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants