Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let exporter inherit from SlidesExporter to expose more resources #298

Closed
wants to merge 2 commits into from

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Jul 11, 2019

Hello,

With this change, we are paving the way for the reveal template. Without it, using the reveal template yields a 500 Internal Server Error.

Steps to reproduce:

voila rise_example.ipynb --template=reveal

We now have

ipdb> VoilaExporter.mro()                                                                                                                  
[<class 'voila.exporter.VoilaExporter'>, <class 'nbconvert.exporters.slides.SlidesExporter'>, <class 'nbconvert.exporters.html.HTMLExporter'>, <class 'nbconvert.exporters.templateexporter.TemplateExporter'>, <class 'nbconvert.exporters.exporter.Exporter'>, <class 'traitlets.config.configurable.LoggingConfigurable'>, <class 'traitlets.config.configurable.Configurable'>, <class 'traitlets.traitlets.HasTraits'>, <class 'traitlets.traitlets.HasDescriptors'>, <class 'object'>]

instead of

ipdb> VoilaExporter.mro()                                                                                                                  
[<class 'voila.exporter.VoilaExporter'>, <class 'nbconvert.exporters.html.HTMLExporter'>, <class 'nbconvert.exporters.templateexporter.TemplateExporter'>, <class 'nbconvert.exporters.exporter.Exporter'>, <class 'traitlets.config.configurable.LoggingConfigurable'>, <class 'traitlets.config.configurable.Configurable'>, <class 'traitlets.traitlets.HasTraits'>, <class 'traitlets.traitlets.HasDescriptors'>, <class 'object'>]

/cc @maartenbreddels

@mkcor
Copy link
Member Author

mkcor commented Jul 12, 2019

We won't have the voila exporter inherit from SlidesExporter (see discussion on Gitter).
Using this branch just for experimentation from now on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant