Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nbconvert #404

Merged
merged 2 commits into from Oct 8, 2019
Merged

Update nbconvert #404

merged 2 commits into from Oct 8, 2019

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Oct 8, 2019 •
edited

This will hopefully fix the CI

@martinRenou martinRenou changed the title Update nbconvert in travis Update nbconvert Oct 8, 2019
@vidartf
Copy link
Contributor

vidartf commented Oct 8, 2019 •
edited

As long as the filter does not remove any cell cells where the output is populated later (I'm not sure what cell.outputs is in that case), this is OK as well.

@martinRenou
Copy link
Member Author

I suppose you wanted to comment on the #405 PR :) But yeah you've got a point. We need to think more about all of this. :empty might be better then, but :empty requires not having any line returns... Which is an annoying constraint for the template.

@SylvainCorlay
Copy link
Member

Merging even though it does not fully fix the CI.

@SylvainCorlay SylvainCorlay merged commit 92dd42f into voila-dashboards:master Oct 8, 2019
@martinRenou martinRenou deleted the update_nbconvert_travis branch October 8, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinRenou @vidartf @SylvainCorlay