Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the ability to hide cells based on cell tags #418

Conversation

AartGoossens
Copy link
Member

This PR documents the ability to hide code and output cells based on cell tags.
Related issue: #171

@AartGoossens
Copy link
Member Author

I also changed some headings to proper markdown headings so you can directly link to subsections in the README.

@jtpio
Copy link
Member

jtpio commented Oct 13, 2019

Many thanks @AartGoossens for this.

I wonder if these instructions could also go to the documentation, under the customizing section? https://voila.readthedocs.io/en/latest/customize.html

@jtpio
Copy link
Member

jtpio commented Oct 13, 2019

And this should also fix #171.

@AartGoossens AartGoossens force-pushed the feature/adds_hiding_cells_to_readme branch from 36e1a96 to 7d993d4 Compare October 14, 2019 13:53
@AartGoossens
Copy link
Member Author

I updated the PR: moved the documentation to docs/source/customize.rst (which is indeed a much better place).

Let me know what else I can do before this can be merged.

docs/source/customize.rst Outdated Show resolved Hide resolved
docs/source/customize.rst Outdated Show resolved Hide resolved
docs/source/customize.rst Outdated Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Oct 16, 2019

Thanks again @AartGoossens, left a couple of inline comments (minor typos).

@AartGoossens AartGoossens force-pushed the feature/adds_hiding_cells_to_readme branch from 7d993d4 to 20bf298 Compare October 17, 2019 17:50
@AartGoossens
Copy link
Member Author

@jtpio Thanks for taking a good look and noticing the typos. :)
I fixed them and pushed my changes.

@maartenbreddels maartenbreddels force-pushed the feature/adds_hiding_cells_to_readme branch from 20bf298 to 70b08f0 Compare August 18, 2020 12:17
@maartenbreddels maartenbreddels force-pushed the feature/adds_hiding_cells_to_readme branch from 70b08f0 to 6d7d858 Compare August 18, 2020 12:18
@maartenbreddels
Copy link
Member

good catch @SylvainCorlay :)

@SylvainCorlay SylvainCorlay merged commit 369ac0b into voila-dashboards:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants