add auto port detection as in jupyter notebook #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @katsar0v for looking at this. |
jtpio
reviewed
Oct 13, 2019
voila/app.py
Outdated
| break | ||
|
|
||
| if not success: | ||
| self.log.critical(_('ERROR: the notebook server could not be started because ' |
There was a problem hiding this comment.
We probably want to say "voila" here.
There was a problem hiding this comment.
I made a new commit and squashed the old ones :)
Add missing import in app.py Update app.py - fix e128 indentation flake8 rule Update app.py - flake8 e124 compatibility rename notebook to voila in the critical message
jtpio
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Thanks @katsar0v, tested locally and it works great.
As mentioned in #392 (comment), this is supposed to be replaced by #270 in the long run.
Until then it's still a useful thing to have.
Leaving it open for a while in case someone has an objection.
Comment on lines
+526
to
+528
| break | ||
|
|
||
| if not success: |
There was a problem hiding this comment.
could be a single else. e.g.
for port in ...
...
else:
...
maartenbreddels
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392 :)