Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: content_manager was not a trait #691

Merged
merged 2 commits into from Sep 3, 2020
Merged

fix: content_manager was not a trait #691

merged 2 commits into from Sep 3, 2020

Conversation

maartenbreddels
Copy link
Member

Equivalent of #690, now using traitlets, fix for #689

@maartenbreddels maartenbreddels force-pushed the fix_contents_manager_traitlets5 branch 2 times, most recently from 20ebc19 to dcf5190 Compare September 2, 2020 18:23
@maartenbreddels maartenbreddels mentioned this pull request Sep 2, 2020
Closed
@maartenbreddels
Copy link
Member Author

I think the problem is that we use --ServerApp.token='', which is now the Python string "''" (e.g. not an empty string!) in trailets 5 :(
this must also effect all notebook users I guess?

@SylvainCorlay
Copy link
Member

I removed your last commit working around the None bug which is solved in traitlets 5.0.3.

@SylvainCorlay SylvainCorlay merged commit 2a0518c into voila-dashboards:master Sep 3, 2020
@maartenbreddels maartenbreddels deleted the fix_contents_manager_traitlets5 branch September 7, 2020 07:33
@maartenbreddels maartenbreddels mentioned this pull request Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maartenbreddels @SylvainCorlay