Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript and tsconfig.json #818

Merged
merged 7 commits into from Feb 4, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 27, 2021

Fixes #809

Opening early so we can multiple passes on this if needed to gradually add typings.

TODO

  • Add typescript and tsconfig.json
  • Rename files to .ts
  • Add typings
  • Fix ESLint warnings
  • Remove allowJs in tsconfig.json

@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2021

cc @JohanMabille since you were also interested in looking into this.

This is the first step to move to TypeScript, and there are still quite a few any to fix (here or in follow-up PRs).

@jtpio jtpio marked this pull request as ready for review January 27, 2021 17:29
@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2021

Another follow-up task would be to try updating to more recent packages.

@JohanMabille
Copy link
Member

Thanks for pinging me @jtpio I have been swamped with other tasks and could not start this one :s

@SylvainCorlay
Copy link
Member

@jtpio should we get this in?

@jtpio
Copy link
Member Author

jtpio commented Feb 4, 2021

Sure.

As mentioned above this might need one more pass, but can be iterated on in follow-up PRs.

@SylvainCorlay
Copy link
Member

Thanks!

I am looking at something that may conflict with this so, merging now!

@SylvainCorlay SylvainCorlay merged commit 4cf9585 into voila-dashboards:master Feb 4, 2021
@jtpio jtpio deleted the typescript branch February 4, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to TypeScript for the Voila frontend
3 participants